You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2014/07/09 23:07:44 UTC
Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Justin Ross, and Rafael Schloming.
Bugs: proton-630
https://issues.apache.org/jira/browse/proton-630
Repository: qpid
Description
-------
Work in progress - generate a setup.py suitable for package management via Pypi
At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
Need to do more testing.
Diffs
-----
/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
/proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
Diff: https://reviews.apache.org/r/23376/diff/
Testing
-------
tested 'setup.py build/install" by hand.
Thanks,
Kenneth Giusti
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Kenneth Giusti <kg...@apache.org>.
> On July 10, 2014, 8:39 a.m., Dominic Evans wrote:
> > Couple of minor comments:
> > * browsing the pypi package list, perhaps the package name should be python-qpid-proton or pyqpid-proton, having <prefix>-python seemed unusual
> > * could we have a cmdline option on setup.py to specify the location in which to find libqpid-proton and the include headers? e.g., ``python setup.py configure --include=/usr/src/qpid-proton-0.7/proton-c/include --libdir=/usr/src/qpid-proton-0.7/build/proton-c``
Thanks for the feedback - I've updated the patch with those changes. It's a little unclear (to me) how distutils expects custom command line parameters to be passed - I basically hacked the sys.argv directly, removing the proton option before running setup() to avoid any potential conflicts. For now I just passed a simple flag indicating that the install is being done via make install, and that causes setup.py() to use the installation path set by cmake to find the necessary C headers and libraries for linking the C wrapper. This works should -DCMAKE_INSTALL_PREFIX or DESTDIR= is used for the install.
- Kenneth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/#review47557
-----------------------------------------------------------
On July 11, 2014, 8:10 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23376/
> -----------------------------------------------------------
>
> (Updated July 11, 2014, 8:10 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.
>
>
> Bugs: proton-630
> https://issues.apache.org/jira/browse/proton-630
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Work in progress - generate a setup.py suitable for package management via Pypi
>
> At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
>
> Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
>
> Need to do more testing.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
> /proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23376/diff/
>
>
> Testing
> -------
>
> tested 'setup.py build/install" by hand.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Dominic Evans <do...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/#review47557
-----------------------------------------------------------
Couple of minor comments:
* browsing the pypi package list, perhaps the package name should be python-qpid-proton or pyqpid-proton, having <prefix>-python seemed unusual
* could we have a cmdline option on setup.py to specify the location in which to find libqpid-proton and the include headers? e.g., ``python setup.py configure --include=/usr/src/qpid-proton-0.7/proton-c/include --libdir=/usr/src/qpid-proton-0.7/build/proton-c``
- Dominic Evans
On July 9, 2014, 9:07 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23376/
> -----------------------------------------------------------
>
> (Updated July 9, 2014, 9:07 p.m.)
>
>
> Review request for qpid, Gordon Sim, Justin Ross, and Rafael Schloming.
>
>
> Bugs: proton-630
> https://issues.apache.org/jira/browse/proton-630
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Work in progress - generate a setup.py suitable for package management via Pypi
>
> At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
>
> Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
>
> Need to do more testing.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
> /proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23376/diff/
>
>
> Testing
> -------
>
> tested 'setup.py build/install" by hand.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Justin Ross <jr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/#review48420
-----------------------------------------------------------
Ship it!
Ship It!
- Justin Ross
On July 17, 2014, 7:36 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23376/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:36 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.
>
>
> Bugs: proton-630
> https://issues.apache.org/jira/browse/proton-630
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Work in progress - generate a setup.py suitable for package management via Pypi
>
> At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
>
> Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
>
> Need to do more testing.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
> /proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23376/diff/
>
>
> Testing
> -------
>
> tested 'setup.py build/install" by hand.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/
-----------------------------------------------------------
(Updated July 17, 2014, 7:36 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.
Changes
-------
Added a huge hard-to-ignore help text that gets printed should setup fail, reminding the user that the proton development libraries need to be pre-installed.
Bugs: proton-630
https://issues.apache.org/jira/browse/proton-630
Repository: qpid
Description
-------
Work in progress - generate a setup.py suitable for package management via Pypi
At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
Need to do more testing.
Diffs (updated)
-----
/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
/proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
Diff: https://reviews.apache.org/r/23376/diff/
Testing
-------
tested 'setup.py build/install" by hand.
Thanks,
Kenneth Giusti
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/
-----------------------------------------------------------
(Updated July 14, 2014, 2:25 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.
Changes
-------
Updated patch to include a 'long description' text, and I've changed the --proton-install to --proton-install-prefix <path>, which is just a tiny bit less hacky IMHO.
Bugs: proton-630
https://issues.apache.org/jira/browse/proton-630
Repository: qpid
Description
-------
Work in progress - generate a setup.py suitable for package management via Pypi
At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
Need to do more testing.
Diffs (updated)
-----
/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
/proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
Diff: https://reviews.apache.org/r/23376/diff/
Testing
-------
tested 'setup.py build/install" by hand.
Thanks,
Kenneth Giusti
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/
-----------------------------------------------------------
(Updated July 11, 2014, 8:10 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.
Bugs: proton-630
https://issues.apache.org/jira/browse/proton-630
Repository: qpid
Description
-------
Work in progress - generate a setup.py suitable for package management via Pypi
At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
Need to do more testing.
Diffs (updated)
-----
/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
/proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
Diff: https://reviews.apache.org/r/23376/diff/
Testing
-------
tested 'setup.py build/install" by hand.
Thanks,
Kenneth Giusti
Re: Review Request 23376: [proton][python] Create a setup.py for the python
bindings.
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/
-----------------------------------------------------------
(Updated July 11, 2014, 2:22 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.
Bugs: proton-630
https://issues.apache.org/jira/browse/proton-630
Repository: qpid
Description
-------
Work in progress - generate a setup.py suitable for package management via Pypi
At this point, it merely generates the setup.py file into the build directory. It also creates a source tarball during install - right now just for a sanity check more than anything.
Ideally, it would be great to have 'make install' actually do 'python setup.py install' when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX isn't in your paths during 'make install'.
Need to do more testing.
Diffs
-----
/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465
/proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION
Diff: https://reviews.apache.org/r/23376/diff/
Testing
-------
tested 'setup.py build/install" by hand.
Thanks,
Kenneth Giusti