You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/10/30 16:02:25 UTC
[GitHub] [myfaces] cristof opened a new pull request, #366: Fixing localized composite behaviour
cristof opened a new pull request, #366:
URL: https://github.com/apache/myfaces/pull/366
Fixes MYFACES-4491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)
Posted by GitBox <gi...@apache.org>.
tandraschko commented on code in PR #366:
URL: https://github.com/apache/myfaces/pull/366#discussion_r1017675637
##########
api/src/main/java/jakarta/faces/component/UIComponent.java:
##########
@@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue)
}
}
}
+
+ private Resource getLocalizedCompositeResource(String resourceName, String libraryName, FacesContext context)
+ {
+ List<String> localizedPaths = getLocalizedPropertiesPaths(resourceName, context);
+ Resource resource = null;
+
+ for (String path_: localizedPaths) {
+ resource = context.getApplication().getResourceHandler().createResource(path_, libraryName);
+ if (resource != null)
Review Comment:
please dont use tabs and make { in new line
no idea, i thought our checkstyle would fail
also better name path_ into localizedPath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] cristof commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)
Posted by GitBox <gi...@apache.org>.
cristof commented on code in PR #366:
URL: https://github.com/apache/myfaces/pull/366#discussion_r1017812955
##########
api/src/main/java/jakarta/faces/component/UIComponent.java:
##########
@@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue)
}
}
}
+
+ private Resource getLocalizedCompositeResource(String resourceName, String libraryName, FacesContext context)
+ {
+ List<String> localizedPaths = getLocalizedPropertiesPaths(resourceName, context);
+ Resource resource = null;
+
+ for (String path_: localizedPaths) {
+ resource = context.getApplication().getResourceHandler().createResource(path_, libraryName);
+ if (resource != null)
Review Comment:
Sorry about that. Fixed style in all four pull requests. Checkstyle did not catch the issue in any branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #366: Fixing localized composite behaviour (3.0.x)
Posted by GitBox <gi...@apache.org>.
melloware merged PR #366:
URL: https://github.com/apache/myfaces/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] cristof commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)
Posted by GitBox <gi...@apache.org>.
cristof commented on code in PR #366:
URL: https://github.com/apache/myfaces/pull/366#discussion_r1017812955
##########
api/src/main/java/jakarta/faces/component/UIComponent.java:
##########
@@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue)
}
}
}
+
+ private Resource getLocalizedCompositeResource(String resourceName, String libraryName, FacesContext context)
+ {
+ List<String> localizedPaths = getLocalizedPropertiesPaths(resourceName, context);
+ Resource resource = null;
+
+ for (String path_: localizedPaths) {
+ resource = context.getApplication().getResourceHandler().createResource(path_, libraryName);
+ if (resource != null)
Review Comment:
Sorry about that. Fixed style in all four pull requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org