[jira] [Commented] (SSHD-375) Buffer.MAX_LEN and DefaultSftpClient#write() don't play well together

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230366#comment-14230366 ] 

Guillaume Nodet commented on SSHD-375:
--------------------------------------

I'll fix the buffer instead. There is no need to have this limitation inside the buffer class itself, it's already in the channel data streams.

https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=commit;h=28900cf51cf20525816659fc0466369a79f667ba

> Buffer.MAX_LEN and DefaultSftpClient#write() don't play well together
> ---------------------------------------------------------------------
>
>                 Key: SSHD-375
>                 URL: https://issues.apache.org/jira/browse/SSHD-375
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.13.0
>            Reporter: Doug Tucker
>             Fix For: 0.14.0
>
>         Attachments: 0001-SSHD-375-implement-internal-chunking-in-DefaultSftpC.patch
>
>
> if you make a call to the write() method with a number bigger than Buffer.MAX_LEN, Buffer.getBytes() will throw an IllegalStateException. 
> TO DO: investigate further usages of Buffer#getString and Buffer#getBytes and see if any of this bug manifests itself elsewhere and, if so, do we want to migrate the "chunking" logic within Buffer?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)