[GitHub] [rocketmq] yuz10 commented on a change in pull request #4029: [ISSUE #4028] wrong log output

[GitBox <gi...@apache.org>]

yuz10 commented on a change in pull request #4029:
URL: https://github.com/apache/rocketmq/pull/4029#discussion_r834449803



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/EndTransactionProcessor.java
##########
@@ -238,7 +238,8 @@ private RemotingCommand sendFinalMessage(MessageExtBrokerInner msgInner) {
                 case MESSAGE_ILLEGAL:
                 case PROPERTIES_SIZE_EXCEEDED:
                     response.setCode(ResponseCode.MESSAGE_ILLEGAL);
-                    response.setRemark("The message is illegal, maybe msg body or properties length not matched. msg body length limit 128k, msg properties length limit 32k.");
+                    response.setRemark(String.format("The message is illegal, maybe msg body or properties length not matched. msg body length limit %dB, msg properties length limit 32KB.",

Review comment:
       Maybe better to show size in KB or MB?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org