You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Marcus Sorensen <sh...@gmail.com> on 2013/04/17 21:00:31 UTC
Review Request: Throw LibvirtException so that VM start failures are noticed,
fix related NPE that can happen when VM starts fail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10591/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
See bug report
This addresses bug CLOUDSTACK-2067.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 373445e
Diff: https://reviews.apache.org/r/10591/diff/
Testing
-------
Tested with latest 4.1 as of time of writing. VMs now don't report success when libvirt fails to start them, but still report success when they start.
Thanks,
Marcus Sorensen
Re: Review Request: Throw LibvirtException so that VM start failures are
noticed, fix related NPE that can happen when VM starts fail
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10591/#review19346
-----------------------------------------------------------
Ship it!
Ship It!
- Chip Childers
On April 17, 2013, 7 p.m., Marcus Sorensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10591/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 7 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> See bug report
>
>
> This addresses bug CLOUDSTACK-2067.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 373445e
>
> Diff: https://reviews.apache.org/r/10591/diff/
>
>
> Testing
> -------
>
> Tested with latest 4.1 as of time of writing. VMs now don't report success when libvirt fails to start them, but still report success when they start.
>
>
> Thanks,
>
> Marcus Sorensen
>
>