You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by " Kaige Liu (JIRA)" <ji...@apache.org> on 2016/11/18 10:10:00 UTC

[jira] [Commented] (KYLIN-2208) Unclosed FileReader in HiveCmdBuilder#build()

    [ https://issues.apache.org/jira/browse/KYLIN-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676368#comment-15676368 ] 

 Kaige Liu commented on KYLIN-2208:
-----------------------------------

Fixed. 
1. Remove the temp file.
2. Use FileUtils to close file.


> Unclosed FileReader in HiveCmdBuilder#build()
> ---------------------------------------------
>
>                 Key: KYLIN-2208
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2208
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee:  Kaige Liu
>            Priority: Minor
>         Attachments: KYLIN-2208_fix_unclosed_filereader.patch
>
>
> {code}
>                 if (logger.isDebugEnabled()) {
>                     logger.debug("The SQL to execute in beeline: \n" + IOUtils.toString(new FileReader(tmpHql)));
> {code}
> FileReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)