You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2021/07/27 16:23:46 UTC

[commons-net] branch master updated: Debugging for GitHub builds

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git


The following commit(s) were added to refs/heads/master by this push:
     new 6595490  Debugging for GitHub builds
6595490 is described below

commit 6595490306f7b40b1335de23ae859cbfab81bca5
Author: Sebb <se...@apache.org>
AuthorDate: Tue Jul 27 17:23:38 2021 +0100

    Debugging for GitHub builds
---
 .github/workflows/maven.yml                               |  9 +++++----
 .../java/org/apache/commons/net/ftp/FTPSClientTest.java   | 15 +++++++++++++++
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index e4c3d00..f4aa47f 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -25,11 +25,12 @@ jobs:
     continue-on-error: ${{ matrix.experimental }}
     strategy:
       matrix:
-        java: [ 8, 11, 16 ]
+        java: [ 11 ]
+        # java: [ 8, 11, 16 ]
         experimental: [false]
-        include:
-          - java: 17-ea
-            experimental: true        
+        # include:
+        #   - java: 17-ea
+        #     experimental: true        
 
     steps:
     - uses: actions/checkout@v2.3.4
diff --git a/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java b/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java
index 08d11ef..a43a4bb 100644
--- a/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java
@@ -104,8 +104,10 @@ public class FTPSClientTest {
      */
     private synchronized static void setUpClass(final boolean implicit) throws FtpException {
         if (EmbeddedFtpServer != null) {
+            System.err.println("Server already active");
             return;
         }
+        System.err.println("Server startup");
         // Use an ephemeral port.
         SocketPort = 0;
         final FtpServerFactory serverFactory = new FtpServerFactory();
@@ -144,11 +146,13 @@ public class FTPSClientTest {
         serverFactory.addListener("default", factory.createListener());
 
         // start the server
+        System.err.println("Server starting");
         EmbeddedFtpServer = serverFactory.createServer();
         EmbeddedFtpServer.start();
         SocketPort = ((org.apache.ftpserver.impl.DefaultFtpServer) EmbeddedFtpServer).getListener("default").getPort();
         ConnectionUri = "ftps://test:test@localhost:" + SocketPort;
         // System.out.printf("jdk.tls.disabledAlgorithms = %s%n", System.getProperty("jdk.tls.disabledAlgorithms"));
+        System.err.println("Server started");
     }
 
     @Parameters(name = "endpointCheckingEnabled={0}")
@@ -168,6 +172,7 @@ public class FTPSClientTest {
     }
 
     private FTPSClient loginClient() throws SocketException, IOException {
+        System.err.println(">>loginClient");
         final FTPSClient client = new FTPSClient(IMPLICIT);
         //
         client.setControlKeepAliveReplyTimeout(null);
@@ -202,6 +207,7 @@ public class FTPSClientTest {
         //
         client.execPROT("P");
         assertClientCode(client);
+        System.err.println("<<loginClient");
         return client;
     }
 
@@ -219,6 +225,7 @@ public class FTPSClientTest {
 
     @Test
     public void testHasFeature() throws SocketException, IOException {
+        System.err.println(">>testHasFeature");
         loginClient().disconnect();
     }
 
@@ -235,26 +242,31 @@ public class FTPSClientTest {
 
     @Test
     public void testListFilesPathNameEmpty() throws SocketException, IOException {
+        System.err.println(">>testListFilesPathNameEmpty");
         testListFiles("");
     }
 
     @Test
     public void testListFilesPathNameJunk() throws SocketException, IOException {
+        System.err.println(">>testListFilesPathNameJunk");
         testListFiles("   Junk   ");
     }
 
     @Test
     public void testListFilesPathNameNull() throws SocketException, IOException {
+        System.err.println(">>testListFilesPathNameNull");
         testListFiles(null);
     }
 
     @Test
     public void testListFilesPathNameRoot() throws SocketException, IOException {
+        System.err.println(">>testListFilesPathNameRoot");
         testListFiles("/");
     }
 
     @Test
     public void testMdtmCalendar() throws SocketException, IOException {
+        System.err.println(">>testMdtmCalendar");
         testMdtmCalendar("/file.txt");
     }
 
@@ -292,6 +304,7 @@ public class FTPSClientTest {
 
     @Test
     public void testMdtmInstant() throws SocketException, IOException {
+        System.err.println(">>testMdtmInstant");
         testMdtmInstant("/file.txt");
     }
 
@@ -311,6 +324,7 @@ public class FTPSClientTest {
 
     @Test
     public void testOpenClose() throws SocketException, IOException {
+        System.err.println(">>testOpenClose");
         final FTPSClient ftpsClient = loginClient();
         try {
             assertTrue(ftpsClient.hasFeature("MODE"));
@@ -322,6 +336,7 @@ public class FTPSClientTest {
 
     @Test
     public void testRetrieveFilePathNameRoot() throws SocketException, IOException {
+        System.err.println(">>testRetrieveFilePathNameRoot");
         retrieveFile("/file.txt");
     }
 }