You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/18 09:00:17 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #9519: Ability to Delete task logs and segments from Google Storage

clintropolis commented on a change in pull request #9519: Ability to Delete task logs and segments from Google Storage
URL: https://github.com/apache/druid/pull/9519#discussion_r394188865
 
 

 ##########
 File path: extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java
 ##########
 @@ -37,11 +38,18 @@
   private static final Logger LOG = new Logger(GoogleDataSegmentKiller.class);
 
   private final GoogleStorage storage;
+  private final GoogleAccountConfig accountConfig;
+  private final GoogleInputDataConfig inputDataConfig;
 
   @Inject
-  public GoogleDataSegmentKiller(final GoogleStorage storage)
+  public GoogleDataSegmentKiller(
+      final GoogleStorage storage,
+      GoogleAccountConfig accountConfig,
+      GoogleInputDataConfig inputDataConfig)
 
 Review comment:
   formatting
   ```suggestion
         GoogleInputDataConfig inputDataConfig
     )
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org