[jira] [Commented] (JCRVLT-841) Avoid checking nodes for inclusion twice

["Joerg Hoh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057891#comment-18057891 ] 

Joerg Hoh commented on JCRVLT-841:
----------------------------------

I looked through the code, and while the above description is true, only children are checked for inclusion twice, which are covered by the filter. Plus the combination that these must be non-orderable children.

So I think that the positive impact on runtime is quite limited, especially when the majority of the repository nodes use nodetypes which are orderable.

> Avoid checking nodes for inclusion twice
> ----------------------------------------
>
>                 Key: JCRVLT-841
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-841
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 4.1.4
>            Reporter: Joerg Hoh
>            Priority: Major
>
> In AggregateImpl.walk() the children of all nodes, which have orderedChildren, are checked twice if they are included in the filter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)