You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/08/03 17:08:53 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1667: Fix #1663 - Missing metrics files running CI tests

ctubbsii commented on a change in pull request #1667:
URL: https://github.com/apache/accumulo/pull/1667#discussion_r464545302



##########
File path: test/pom.xml
##########
@@ -270,6 +270,15 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-jar-plugin</artifactId>
+        <configuration>
+          <excludes>
+            <exclude>**/hadoop-metrics2-accumulo.properties</exclude>

Review comment:
       It occurs to me... does this still allow metrics to work when we're doing testing? If it's not in the jar, how does it get on the class path?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org