You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/02/05 03:04:26 UTC
Review Request 43237: Add benchmark for feching tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository: aurora
Description
-------
This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
Diff: https://reviews.apache.org/r/43237/diff/
Testing
-------
./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
Thanks,
Zameer Manji
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review117940
-----------------------------------------------------------
Master (505f310) is red with this patch.
./build-support/jenkins/build.sh
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:1: error: Line does not match expected header line of '^\/\*\*$'.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:45:12: error: 'public' modifier out of order with the JLS suggestions.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:47:14: error: 'public' modifier out of order with the JLS suggestions.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:52:34: error: 'numTasks' hides a field.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:72: error: 'member def type' have incorrect indentation level 5, expected level should be 6.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:72: error: 'method def' child have incorrect indentation level 5, expected level should be 6.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:75: error: 'method def modifier' have incorrect indentation level 12, expected level should be one of the following: 9, 11, 13.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:77: error: 'method def' child have incorrect indentation level 14, expected level should be one of the following: 11, 13, 15.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:78: error: 'method def rcurly' have incorrect indentation level 12, expected level should be one of the following: 9, 11, 13.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java:79: error: 'object def rcurly' have incorrect indentation level 10, expected level should be one of the following: 7, 9, 11.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleJmh'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/jmh.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 2 mins 12.026 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 5, 2016, 2:04 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 2:04 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43237/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
>
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review118064
-----------------------------------------------------------
Ship it!
Master (9b7c72e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 5, 2016, 6:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 6:57 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43237/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
>
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Zameer Manji <zm...@apache.org>.
> On Feb. 5, 2016, 11:05 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java, line 64
> > <https://reviews.apache.org/r/43237/diff/3/?file=1236394#file1236394line64>
> >
> > storeTasks or createTasks? Otherwise it's confusing to see loadTasks here and fetchTasks in the benchmark.
renamed to `createTasks`.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review118058
-----------------------------------------------------------
On Feb. 5, 2016, 10:57 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:57 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43237/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
>
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review118058
-----------------------------------------------------------
Ship it!
src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java (line 64)
<https://reviews.apache.org/r/43237/#comment179326>
storeTasks or createTasks? Otherwise it's confusing to see loadTasks here and fetchTasks in the benchmark.
- Maxim Khutornenko
On Feb. 5, 2016, 6:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 6:57 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43237/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
>
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review118148
-----------------------------------------------------------
Ship it!
- Bill Farner
On Feb. 5, 2016, 10:57 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:57 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43237/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
>
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/#review118197
-----------------------------------------------------------
Ship it!
Master (2d59b69) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 7, 2016, 10:49 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43237/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 10:49 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43237/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
>
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
> TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
> TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/
-----------------------------------------------------------
(Updated Feb. 7, 2016, 2:49 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Maxim's feedback.
Repository: aurora
Description
-------
This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
Diff: https://reviews.apache.org/r/43237/diff/
Testing
-------
./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
Thanks,
Zameer Manji
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 10:57 a.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Fix style issues.
Repository: aurora
Description
-------
This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
Diff: https://reviews.apache.org/r/43237/diff/
Testing
-------
./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
Thanks,
Zameer Manji
Re: Review Request 43237: Add benchmark for feching tasks.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43237/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 6:04 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Fix typo.
Repository: aurora
Description
-------
This adds a benchmark for the throughput of fetching tasks from both the DB and InMem store.
Diffs (updated)
-----
src/jmh/java/org/apache/aurora/benchmark/TaskStoreBenchmarks.java PRE-CREATION
Diff: https://reviews.apache.org/r/43237/diff/
Testing
-------
./gradlew jmh -Pbenchmarks='TaskStoreBenchmarks.*'
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 10000 thrpt 5 44.395 ± 15.378 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 50000 thrpt 5 0.184 ± 0.013 ops/s
TaskStoreBenchmarks.DBFetchTasksBenchmark.run 100000 thrpt 5 0.077 ± 0.037 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 10000 thrpt 5 562.370 ± 768.131 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 50000 thrpt 5 81.901 ± 28.108 ops/s
TaskStoreBenchmarks.MemFetchTasksBenchmark.run 100000 thrpt 5 38.883 ± 14.443 ops/s
Thanks,
Zameer Manji