You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/11 16:03:38 UTC
[kudu-CR] [java] Update dependencies and plugins
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9990
Change subject: [java] Update dependencies and plugins
......................................................................
[java] Update dependencies and plugins
Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
---
M docs/release_notes.adoc
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradlew
M java/kudu-client/pom.xml
M java/pom.xml
7 files changed, 59 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/9990/1
--
To view, visit http://gerrit.cloudera.org:8080/9990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
Gerrit-Change-Number: 9990
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Update dependencies and plugins
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9990 )
Change subject: [java] Update dependencies and plugins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9990/1/java/pom.xml
File java/pom.xml:
http://gerrit.cloudera.org:8080/#/c/9990/1/java/pom.xml@74
PS1, Line 74: <!-- TODO: 24.1-android -->
Can this version be updated now? It's already updated on the Gradle side so I presume everything is cool.
--
To view, visit http://gerrit.cloudera.org:8080/9990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
Gerrit-Change-Number: 9990
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 17:23:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Update dependencies and plugins
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9990 )
Change subject: [java] Update dependencies and plugins
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
Gerrit-Change-Number: 9990
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 11 Apr 2018 20:07:44 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Update dependencies and plugins
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9990 )
Change subject: [java] Update dependencies and plugins
......................................................................
[java] Update dependencies and plugins
Note: Also removes a use of Objects.toStringHelper in
kudu-mapreduce as a workaround to maven’s shaded
module dependency issues and breaking Guava changes.
Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
Reviewed-on: http://gerrit.cloudera.org:8080/9990
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/release_notes.adoc
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradlew
M java/kudu-client/pom.xml
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M java/pom.xml
8 files changed, 68 insertions(+), 47 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
Gerrit-Change-Number: 9990
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Update dependencies and plugins
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9990
to look at the new patch set (#2).
Change subject: [java] Update dependencies and plugins
......................................................................
[java] Update dependencies and plugins
Note: Also removes a use of Objects.toStringHelper in
kudu-mapreduce as a workaround to maven’s shaded
module dependency issues and breaking Guava changes.
Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
---
M docs/release_notes.adoc
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradlew
M java/kudu-client/pom.xml
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M java/pom.xml
8 files changed, 68 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/9990/2
--
To view, visit http://gerrit.cloudera.org:8080/9990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8323ede9d7aae70bb95086542747704d2dac3a7
Gerrit-Change-Number: 9990
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>