You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Rakesh R (JIRA)" <ji...@apache.org> on 2018/02/06 11:35:00 UTC

[jira] [Comment Edited] (HDFS-13110) [SPS]: Reduce the number of APIs in NamenodeProtocol used by external satisfier

    [ https://issues.apache.org/jira/browse/HDFS-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353750#comment-16353750 ] 

Rakesh R edited comment on HDFS-13110 at 2/6/18 11:34 AM:
----------------------------------------------------------

Note: Attached patch [^HDFS-13110-HDFS-10285-00.patch], is prepared on top of HDFS-13097 work, as latter reduces my coding effort. Please apply [^HDFS-13097-HDFS-10285.02.patch] first , then apply this jira patch. Sorry for the inconvenience.


was (Author: rakeshr):
Note: Attached patch [^HDFS-13110-HDFS-10285-00.patch], is prepared on top of HDFS-13097 , as latter reduces my coding effort. Please apply [^HDFS-13097-HDFS-10285.02.patch] first an then apply this jira patch. Sorry for the inconvenience.

> [SPS]: Reduce the number of APIs in NamenodeProtocol used by external satisfier
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-13110
>                 URL: https://issues.apache.org/jira/browse/HDFS-13110
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Priority: Major
>         Attachments: HDFS-13110-HDFS-10285-00.patch
>
>
> This task is to address the following [~daryn]'s comments. Please refer HDFS-10285 to see more detailed discussion.
> *Comment-10)*
> {quote}
> NamenodeProtocolTranslatorPB
> Most of the api changes appear unnecessary.
> IntraSPSNameNodeContext#getFileInfo swallows all IOEs, based on assumption that any and all IOEs means FNF which probably isn’t the intention during rpc exceptions.
> {quote}
>  *Comment-13)*
> {quote}
> StoragePolicySatisfier
>  It appears to make back-to-back calls to hasLowRedundancyBlocks and getFileInfo for every file. Haven’t fully groked the code, but if low redundancy is not the common case, then it shouldn’t be called unless/until needed. It looks like files that are under replicated are re-queued again?
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org