[kudu-CR] [tserver] Fix bug in AlterSchemaTransactionState::ToString

["XiaokaiWang (Code Review)" <ge...@cloudera.org>]

Hello Kudu Jenkins, Andrew Wong, Yao Xu, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13782

to look at the new patch set (#2).

Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString
......................................................................

[tserver] Fix bug in AlterSchemaTransactionState::ToString

The error_ condition is reversed, When error is null the tserver will crash.

stacktrace:
0x21f5dcc google::protobuf::TextFormat::Printer::Print()
0x21f5e6d google::protobuf::TextFormat::Printer::PrintToString()
0x204e335 kudu::pb_util::SecureShortDebugString()
0xbeae76 kudu::tablet::AlterSchemaTransactionState::ToString()
0xbead3f kudu::tablet::AlterSchemaTransaction::ToString()
0xbedaea kudu::tablet::TransactionDriver::ToString()
0xbf41e1 kudu::tablet::TransactionTracker::WaitForAllToFinish()
0xbf496f kudu::tablet::TransactionTracker::WaitForAllToFinish()
0xbe543f kudu::tablet::TabletReplica::Stop()
0x9cd198 kudu::tserver::TSTabletManager::DeleteTablet()
0x9d2f5f kudu::tserver::DeleteTabletRunnable::Run()
0x207365f kudu::ThreadPool::DispatchThread()
0x2068ec4 kudu::Thread::SuperviseThread()
0x7f01548b2dc5 start_thread
0x7f0152b8dced __clone

Deleting old range partion, which will wait for all txns to finish.
If being dumped txns contains AlterSchema TXN and the txn is executed correct,
tserver will crach.

Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1
---
M src/kudu/tablet/transactions/alter_schema_transaction.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/13782/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1
Gerrit-Change-Number: 13782
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>