You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2023/01/04 09:10:50 UTC
[GitHub] [iotdb] BUAAserein opened a new pull request, #8743: [IOTDB-5284] Fix some code smells
BUAAserein opened a new pull request, #8743:
URL: https://github.com/apache/iotdb/pull/8743
## Description
### Fix some code smells in server [iotdb-server], please see in [JIRA5284](https://issues.apache.org/jira/browse/IOTDB-5284)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8743: [IOTDB-5284] Fix some code smells
Posted by GitBox <gi...@apache.org>.
SpriCoder commented on code in PR #8743:
URL: https://github.com/apache/iotdb/pull/8743#discussion_r1061618180
##########
server/src/main/java/org/apache/iotdb/db/metadata/mtree/store/disk/schemafile/SegmentedPage.java:
##########
@@ -265,17 +265,17 @@ public String inspect() throws SegmentNotFoundException {
StringBuilder builder =
new StringBuilder(
String.format(
- "page_id:%d, total_seg:%d, spare_from:%d, spare_size:%d\n",
+ "page_id:%d, total_seg:%d, spare_from:%d, spare_size:%d%n",
Review Comment:
Why change `\n` to `%n` here? Same problem in follow 3 changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8743: [IOTDB-5284] Fix some code smells
Posted by GitBox <gi...@apache.org>.
OneSizeFitsQuorum merged PR #8743:
URL: https://github.com/apache/iotdb/pull/8743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org