You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2016/03/08 18:40:40 UTC

[jira] [Resolved] (LUCENE-6952) All Filter* delegating classes should be abstract

     [ https://issues.apache.org/jira/browse/LUCENE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley resolved LUCENE-6952.
----------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: master)
                   6.0

> All Filter* delegating classes should be abstract
> -------------------------------------------------
>
>                 Key: LUCENE-6952
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6952
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 6.0
>
>         Attachments: LUCENE_6952.patch, LUCENE_6952.patch
>
>
> I think it's confusing that FilterLeafReader (and it's Filter\* inner classes) are not abstract.  By making them abstract, we clarify to users how to use them by virtue of them being abstract.  It seems only a couple tests directly instantiate them.  This applies to other Filter* classes as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org