[GitHub] [spark] srielau commented on pull request #37887: [SPARK-40360] ALREADY_EXISTS and NOT_FOUND exceptions

[GitBox <gi...@apache.org>]

srielau commented on PR #37887:
URL: https://github.com/apache/spark/pull/37887#issuecomment-1279218243

   @MaxGekk @cloud-fan 
   Since the last review I have:
   * eliminated tolerance for not having context and added all the contexts
   * removed replaced template error codes
   * addressed minor comments
   * added namespace related error messages in error-classes.json
   
   What I have NOT done and need help with:
   * One remaining failure where I don't know how to generate the correct fragment in a multimode test. I have reached out to @gengliangwang to assist
   * Pull checkErrorTableNotFound() out of SparkFunSuite. In fact, in a way, its now worse because of new overloading for context
   * Generate NAMESPACE error codes
   
   TBH this PR has been very expensive and impacted timely delivery of DBR docs.
   So I would prefer to roll these two refactors into separate PRs driven by ICs.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org