[jira] Updated: (TOMAHAWK-955) Tomahawk CORE components + tags errors (missing attributes, missing EL-support, missing saving/restoring)

["Zdenek Sochor (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TOMAHAWK-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zdenek Sochor updated TOMAHAWK-955:
-----------------------------------

    Status: Patch Available  (was: Open)

> Tomahawk CORE components + tags errors (missing attributes, missing EL-support, missing saving/restoring)
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-955
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-955
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6-SNAPSHOT
>            Reporter: Zdenek Sochor
>            Priority: Critical
>         Attachments: tomahawk.patch
>
>
> Hi,
>   by walking through sources of core Tomahawk components i found quite a few errors.
> I'll attach patches ASAP for EL, missing attributes and forgotten saving/restoring state of attributes.
> Regard,
>   Zdenek
> Tomahawk CORE components + tags errors
> -------------------------------------------
> package org.apache.myfaces.component.html.ext
> HtmlSelectOneRadio
>    escape - missing (only here from all Select* components)
> HtmlSelectOneMenu
> HtmlSelectOneList
> HtmlSelectManyMenu
> HtmlSelectManyList
> HtmlSelectBooleanCheckbox
>    escape - not saved/restored
> HtmlInputTextarea
>    wrap - not saved/restored, not EL-enabled
> HtmlDataTable
>    newspaperColumns - not EL-enabled (already JIRA issue TOMAHAWK-728)
>    newspaperOrientation
>    varDetailToggler - not EL-enabled
> HtmlCommandLink
>    target - already in superclass (javax.faces.component.html.HtmlCommandLink)
> -------------------------------------------
> package org.apache.myfaces.custom.calendar
> HtmlInputCalendarTag
> 	onblur
> 	onchange
> 	onfocus
> 	onselect - already in superclass (org.apache.myfaces.taglib.html.ext.HtmlInputTextTag)
> HtmlInputCalendar
> 	popupTodayDateFormat - not saved/restored
> -------------------------------------------
> package org.apache.myfaces.custom.collapsiblepanel
> HtmlCollapsiblePanelTag
> 	title - already in superclass (org.apache.myfaces.shared_tomahawk.taglib.html.HtmlComponentTagBase)
> HtmlCollapsiblePanel
> 	style
> 	styleClass - not saved/restored
> -------------------------------------------
> package org.apache.myfaces.custom.crosstable
> HtmlColumns
> 	width - not EL-enabled
> HtmlColumnsTag
> 	colspan - never used in component (empty implementation), suggest removing
> -------------------------------------------
> package org.apache.myfaces.custom.datalist
> HtmlDataList
> 	itemStyleClass - not stored/restored
> --------------------------------------------
> package org.apache.myfaces.custom.date
> HtmlInputDate
> 	html attributes not EL-enabled (wrong hiearchy - refactor to the same one as HtmlInputCalendar)
> --------------------------------------------
> package org.apache.myfaces.custom.fileupload
> HtmlInputFileUploadTag
> 	readonly - already in superclass (org.apache.myfaces.shared_tomahawk.taglib.html.HtmlInputTagBase)
> --------------------------------------------
> package org.apache.myfaces.custom.htmlTag
> HtmlTagTag
> 	style
> 	styleClass - already in superclass (org.apache.myfaces.shared_tomahawk.taglib.html.HtmlComponentTagBase)
> --------------------------------------------
> package org.apache.myfaces.custom.inputHtml
> InputHtml
> 	style
> 	styleClass - already in superclass (import org.apache.myfaces.component.html.ext.HtmlInputText)
> --------------------------------------------
> package org.apache.myfaces.custom.layout
> HtmlPanelLayoutTag
> 	HTML table attributes NOT present in component (TODO comment)
> --------------------------------------------
> package org.apache.myfaces.custom.navigation
> HtmlPanelNavigationTag
> 	HTML table attributes NOT present in component
> --------------------------------------------
> package org.apache.myfaces.custom.navmenu
> HtmlCommandNavigationItemTag
> 	attributes - not released
> NavigationMenuItem
> 	attributes not EL-enabled
> HtmlNavigationMenuItemTag
> 	actionListener
> 	immediate
> 	target
> 	disabled
> 	disabledStyle
> 	disabledStyleClass - not released
> HtmlPanelNavigationMenuTag
> 	HTML table attributes NOT present in component
> --------------------------------------------
> package org.apache.myfaces.custom.navmenu.jscookmenu
> HtmlJSCookMenuTag
> 	immediate - not released
> --------------------------------------------
> org.apache.myfaces.custom.newspaper
> ISN'T DEPRECATED?
> HtmlNewspaperTable
> 	newspaperColumns - not EL-enabled (already JIRA issue TOMAHAWK-728)
> HtmlNewspaperTableTag
> 	newspaperOrientation - not released, never used in component
> --------------------------------------------
> package org.apache.myfaces.custom.radio
> HtmlRadioTag
> 	enabledOnUserRole
> 	visibleOnUserRole - not present in component
> --------------------------------------------
> package org.apache.myfaces.custom.schedule
> ScheduleTag
> 	renderZeroLengthEntries
> 	expandToFitEntries - not released
> --------------------------------------------
> package org.apache.myfaces.custom.tabbedpane
> HtmlPanelTabbedPane
> 	disabledTabStyleClass - not EL-enabled
> 	HTML Table attributes missing (TODO comment)
> --------------------------------------------
> package org.apache.myfaces.custom.tree
> HtmlTreeImageCommandLink
> 	image - not EL-enabled
> HtmlTree
> 	styleClass - already in superclass (javax.faces.component.html.HtmlPanelGroup)
> 	var - not EL-enabled
> --------------------------------------------
> package org.apache.myfaces.custom.tree.taglib
> TreeTag
> 	expireListeners - not released
> TreeSelectionListenerTag
> 	type - not released
> IconProviderTag
> 	type - not released
> --------------------------------------------
> package org.apache.myfaces.taglib.html.ext
> HtmlCommandLinkTag
> 	disabled
> 	disabledStyle
> 	disabledStyleClass - not released
> HtmlSelectBooleanCheckboxTag
> 	escape - missing (only here from all Select* tags)
> HtmlPanelGroupTag
> 	displayValueOnly
> 	displayValueOnlyStyle
> 	displayValueOnlyStyleClass - not released
> HtmlPanelGridTag
> 	align - deprecated, NOT present in component (from tag's superclass)
> 	displayValueOnly
> 	displayValueOnlyStyle
> 	displayValueOnlyStyleClass - not released
> HtmlInputTextTag
> 	datafld
> 	datasrc
> 	dataformatas - NOT present in component
> HtmlInputSecretTag
> 	datafld
> 	datasrc
> 	dataformatas - NOT present in component
> HtmlGraphicImageTag
> 	align
> 	border
> 	hspace
> 	vspace - NOT present in component
> HtmlCommandLinkTag
> 	displayValueOnly
> 	displayValueOnlyStyle
> 	displayValueOnlyStyleClass - not released
> [END]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.