You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/07/17 08:22:59 UTC
[jira] [Created] (CASSANDRA-2906) Streaming SSTable build does not
use cleanupIfNecessary
Streaming SSTable build does not use cleanupIfNecessary
-------------------------------------------------------
Key: CASSANDRA-2906
URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
Project: Cassandra
Issue Type: Bug
Reporter: Stu Hood
Priority: Minor
Fix For: 1.0
The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2906) Streaming SSTable build does
not use cleanupIfNecessary
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067301#comment-13067301 ]
Yuki Morishita commented on CASSANDRA-2906:
-------------------------------------------
Thank you for pointing it out. Patch attached to do perform closeIfNecessary.
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2906) Streaming SSTable build does not
use cleanupIfNecessary
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yuki Morishita updated CASSANDRA-2906:
--------------------------------------
Attachment: trunk-2906-v2.txt
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906-v2.txt, trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2906) Streaming SSTable build does
not use cleanupIfNecessary
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068336#comment-13068336 ]
Yuki Morishita commented on CASSANDRA-2906:
-------------------------------------------
Attached v2. Just return SSTR instead of storing to local var.
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906-v2.txt, trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-2906) Streaming SSTable build does not
use cleanupIfNecessary
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-2906.
---------------------------------------
Resolution: Fixed
Reviewer: stuhood
Assignee: Yuki Morishita
committed
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Assignee: Yuki Morishita
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906-v2.txt, trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2906) Streaming SSTable build does
not use cleanupIfNecessary
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068470#comment-13068470 ]
Hudson commented on CASSANDRA-2906:
-----------------------------------
Integrated in Cassandra #965 (See [https://builds.apache.org/job/Cassandra/965/])
add cleanupIfNecessary for single-pass streaming SSTable build
patch by Yuki Morishita; reviewed by stuhood and jbellis for CASSANDRA-2906
jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148811
Files :
* /cassandra/trunk/src/java/org/apache/cassandra/streaming/IncomingStreamReader.java
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Assignee: Yuki Morishita
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906-v2.txt, trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2906) Streaming SSTable build does
not use cleanupIfNecessary
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067392#comment-13067392 ]
Stu Hood commented on CASSANDRA-2906:
-------------------------------------
You can actually return the reader object from inside the {{try, finally}}: the finally block isn't executed until after the return statement. See the uses of cleanupIfNecessary in SSTableWriter.Builder for an example.
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2906) Streaming SSTable build does not
use cleanupIfNecessary
Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yuki Morishita updated CASSANDRA-2906:
--------------------------------------
Attachment: trunk-2906.txt
> Streaming SSTable build does not use cleanupIfNecessary
> -------------------------------------------------------
>
> Key: CASSANDRA-2906
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2906
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2906.txt
>
>
> The new streaming sstable rebuilding in IncomingStreamReader needs to wrap things in with {{try, finally, cleanupIfNecessary}} to ensure that the writer is cleaned up properly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira