Re: svn commit: rev 7252 - trunk/tools/cvs2svn

[Russell Yanofsky <re...@columbia.edu>]

Max Bowsher wrote:
> Russell Yanofsky wrote:
> ...
> Hmm. Well, please don't commit outside your area even if the testsuite
> passes.

Ok, I won't do that again.

> It failed for me on Cygwin, and began working again after reverting
> your revisions.
> Some of your changes were totally undiscussed. Most of the rest are
> still under discussion.

A new patch is attached, tested successfully on windows, linux, and cygwin.
(For some reason cvs2svn failed with the old patch where a file was opened
in 'wt' mode instead of 'w' mode. I don't know why. All I know is cygwin
scares me...)

This patch restores the changes made in rev 7246 except the one that broke
cygwin. You can restore the change in rev 7247 yourself if it pleases you
:).

Log Message:

Changes to cvs2svn.py and its regression testing script so they will
work on Windows. Restores all changes from rev 7246 except for one
that broke cvs2svn on cygwin.

* tools/cvs2svn/cvs2svn.py
  (relative_name):
    Changed this function to expect os.sep in the file path passed to
    it instead of forward slashes.

  (escape_shell_arg):
    new function to escape shell arguments, works differently on unix
    and windows

  (Dumper.add_or_change_path):
    changed to use the escape_shell_arg function

* tools/cvs2svn/run-tests.py
  (run_cvs2svn):
    changed command line used to start cvs2svn on windows

  (repos_to_url):
    Added missing slash detection. Needed because absolute paths on
    windows begin with a drive letter instead of a slash.

  (svn_strptime):
    new function to take the place of time.strptime, which doesn't
    exist on windows

  (Log.__init__):
    replaced time.strptime() call with svn_strptime() call.