[GitHub] john-bodley opened a new pull request #5062: [markup] Enable allow-forms

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #5062: [markup] Enable allow-forms
URL: https://github.com/apache/incubator-superset/pull/5062
 
 
   This PR fixes an issue where a dashboard contained a markup slice with links to other dashboards, and when one tried to either export or explore a slice on the referenced dashboard the following error occurred:
   
   ```
   Blocked form submission to <url> because the form's frame is sandboxed and the 'allow-forms' permission is not set.
   ```
   The solution is simply to enable the `allow-forms` permission in the markup iframe component. 
   
   Note given the complexity of the issue, I'm unsure whether one could write a unit test for this scenario, though I was able to validate the fix in my local environment. 
   
   to: @graceguo-supercat @michellethomas @mistercrunch  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org