[GitHub] [incubator-inlong] healchow commented on a change in pull request #3522: [INLONG-3514][TubeMQ] Cluster query adds name and IP attributes

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #3522:
URL: https://github.com/apache/incubator-inlong/pull/3522#discussion_r841076612



##########
File path: inlong-tubemq/tubemq-manager/src/main/java/org/apache/inlong/tubemq/manager/service/MasterServiceImpl.java
##########
@@ -156,6 +156,21 @@ public MasterEntry getMasterNode(Long clusterId) {
         return masters;
     }
 
+    @Override
+    public List<MasterEntry> getMasterNodes(String masterIp) {
+        if (masterIp == null) {
+            return null;
+        }
+        List<MasterEntry> masters = masterRepository
+                .findMasterEntryByIpEquals(

Review comment:
       Why separate so many lines?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org