You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/20 13:12:18 UTC
[GitHub] [hudi] YuweiXiao opened a new pull request, #5912: [MINOR] fix parquet max file constraint for flink bulk insert
YuweiXiao opened a new pull request, #5912:
URL: https://github.com/apache/hudi/pull/5912
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
The max parquet write file size is: `compression_ratio * max_file_size`.
The original implementation uses `max_file_size + compression_ratio * max_file_size`, which is not consistent with spark writer.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YuweiXiao commented on a diff in pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
Posted by GitBox <gi...@apache.org>.
YuweiXiao commented on code in PR #5912:
URL: https://github.com/apache/hudi/pull/5912#discussion_r905797066
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetWriter.java:
##########
@@ -49,8 +49,7 @@ public HoodieRowDataParquetWriter(Path file, HoodieRowDataParquetConfig parquetC
this.file = HoodieWrapperFileSystem.convertToHoodiePath(file, parquetConfig.getHadoopConf());
this.fs = (HoodieWrapperFileSystem) this.file.getFileSystem(FSUtils.registerFileSystem(file,
parquetConfig.getHadoopConf()));
- this.maxFileSize = parquetConfig.getMaxFileSize()
- + Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio());
+ this.maxFileSize = Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio());
this.writeSupport = parquetConfig.getWriteSupport();
Review Comment:
Hi Danny, I was referring to `HoodieAppendHandle`. I rechecked the code and found I understand it wrong. I'll close the PR, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5912:
URL: https://github.com/apache/hudi/pull/5912#issuecomment-1160623960
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d4a128b55e766f8bd62128704a4874a9cc6d418",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9399",
"triggerID" : "4d4a128b55e766f8bd62128704a4874a9cc6d418",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d4a128b55e766f8bd62128704a4874a9cc6d418 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9399)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5912:
URL: https://github.com/apache/hudi/pull/5912#issuecomment-1160486278
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d4a128b55e766f8bd62128704a4874a9cc6d418",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9399",
"triggerID" : "4d4a128b55e766f8bd62128704a4874a9cc6d418",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d4a128b55e766f8bd62128704a4874a9cc6d418 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9399)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5912:
URL: https://github.com/apache/hudi/pull/5912#discussion_r905765888
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetWriter.java:
##########
@@ -49,8 +49,7 @@ public HoodieRowDataParquetWriter(Path file, HoodieRowDataParquetConfig parquetC
this.file = HoodieWrapperFileSystem.convertToHoodiePath(file, parquetConfig.getHadoopConf());
this.fs = (HoodieWrapperFileSystem) this.file.getFileSystem(FSUtils.registerFileSystem(file,
parquetConfig.getHadoopConf()));
- this.maxFileSize = parquetConfig.getMaxFileSize()
- + Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio());
+ this.maxFileSize = Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio());
this.writeSupport = parquetConfig.getWriteSupport();
Review Comment:
The logic is referenced from `HoodieBaseParquetWriter`, why you think it is wrong, can you explain more details ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YuweiXiao closed pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
Posted by GitBox <gi...@apache.org>.
YuweiXiao closed pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
URL: https://github.com/apache/hudi/pull/5912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5912:
URL: https://github.com/apache/hudi/pull/5912#issuecomment-1160439471
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d4a128b55e766f8bd62128704a4874a9cc6d418",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4d4a128b55e766f8bd62128704a4874a9cc6d418",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d4a128b55e766f8bd62128704a4874a9cc6d418 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org