You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/12/08 22:54:22 UTC

[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9235: RefCountObj - further improvements wrt copy construction.

ywkaras commented on code in PR #9235:
URL: https://github.com/apache/trafficserver/pull/9235#discussion_r1043899142


##########
include/tscore/Ptr.h:
##########
@@ -47,32 +46,23 @@ class RefCountObj : public ForceVFPTToTop
 {
 public:
   RefCountObj() {}
-  RefCountObj(const RefCountObj &s)
-  {
-    (void)s;
-    return;
-  }
-
+  RefCountObj(const RefCountObj &) = delete;

Review Comment:
   This has to be:
   ```
   RefCountObj(const RefCountObj &)
   {
     m_refcount = 0;
   }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org