You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/16 13:03:51 UTC
[GitHub] [shardingsphere] xuejmnet opened a new pull request, #21597: Update TableExtractor.java
xuejmnet opened a new pull request, #21597:
URL: https://github.com/apache/shardingsphere/pull/21597
防止静态方法多次调用和多次判断转换,当SelectStatement不在对应的if语句里面需要多判断4次
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #21597: Update TableExtractor.java
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #21597:
URL: https://github.com/apache/shardingsphere/pull/21597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21597: Update TableExtractor.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21597:
URL: https://github.com/apache/shardingsphere/pull/21597#issuecomment-1282197300
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21597?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21597](https://codecov.io/gh/apache/shardingsphere/pull/21597?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cadd87b) into [master](https://codecov.io/gh/apache/shardingsphere/commit/faf904057902b49db19b0d807f2ed26b8bd2f945?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (faf9040) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head cadd87b differs from pull request most recent head cff31f6. Consider uploading reports for the commit cff31f6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21597 +/- ##
=========================================
Coverage 61.06% 61.06%
Complexity 2511 2511
=========================================
Files 4111 4111
Lines 57270 57270
Branches 7588 7587 -1
=========================================
Hits 34970 34970
Misses 19363 19363
Partials 2937 2937
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/21597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9leHRyYWN0b3IvVGFibGVFeHRyYWN0b3IuamF2YQ==) | `20.24% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org