You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:05:05 UTC
[GitHub] [incubator-brpc] 0x2Adr1 commented on pull request #1657: Chore: rework Bazel build system
0x2Adr1 commented on PR #1657:
URL: https://github.com/apache/incubator-brpc/pull/1657#issuecomment-1232985061
Looks like I am coming a few minutes too late after the merge! There is a slight change to be made to make it work with Mac M1:
```
--- BUILD.bazel
+++ BUILD.bazel
@@ -48,7 +48,7 @@ LINKOPTS = [
"-pthread",
"-ldl",
] + select({
- "@bazel_tools//tools/osx:darwin": [
+ "@platforms//os:macos": [
"-framework CoreFoundation",
"-framework CoreGraphics",
"-framework CoreData",
@@ -206,7 +206,7 @@ BUTIL_SRCS = [
"src/butil/recordio.cc",
"src/butil/popen.cpp",
] + select({
- "@bazel_tools//tools/osx:darwin": [
+ "@platforms//os:macos": [
"src/butil/time/time_mac.cc",
"src/butil/mac/scoped_mach_port.cc",
],
@@ -322,7 +322,7 @@ cc_library(
"//bazel/config:brpc_with_glog": ["@com_github_google_glog//:glog"],
"//conditions:default": [],
}) + select({
- "@bazel_tools//tools/osx:darwin": [":macos_lib"],
+ "@platforms//os:macos": [":macos_lib"],
"//conditions:default": [],
}),
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org