You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/07 07:21:36 UTC
Review Request 32801: DRILL-2668: Fix: CAST(1.1 AS FLOAT) was yielding
DOUBLE.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32801/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2668
https://issues.apache.org/jira/browse/DRILL-2668
Repository: drill-git
Description
-------
Added test method (and others for parallel cases) to TestFunctionsQuery.
Fixed use of DOUBLE methods/classes for FLOAT:
- Changed a FLOAT -> DOUBLE mapping in ValueExpressions.
- Added parallel FLOAT methods/classes in EvaluationVisitor.
Diffs
-----
common/src/main/java/org/apache/drill/common/expression/ValueExpressions.java e095e7e
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 386ab79
exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java f1005ab
Diff: https://reviews.apache.org/r/32801/diff/
Testing
-------
Ran new specific test and existing tests.
Thanks,
Daniel Barclay
Re: Review Request 32801: DRILL-2668: Fix: CAST(1.1 AS FLOAT) was
yielding DOUBLE.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32801/#review79722
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On April 7, 2015, 5:21 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32801/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 5:21 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2668
> https://issues.apache.org/jira/browse/DRILL-2668
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added test method (and others for parallel cases) to TestFunctionsQuery.
> Fixed use of DOUBLE methods/classes for FLOAT:
> - Changed a FLOAT -> DOUBLE mapping in ValueExpressions.
> - Added parallel FLOAT methods/classes in EvaluationVisitor.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/expression/ValueExpressions.java e095e7e
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java 386ab79
> exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java f1005ab
>
> Diff: https://reviews.apache.org/r/32801/diff/
>
>
> Testing
> -------
>
> Ran new specific test and existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>