[GitHub] [spark] MaxGekk commented on a diff in pull request #41721: [SPARK-44171][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2279-2282] & delete some unused error classes

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #41721:
URL: https://github.com/apache/spark/pull/41721#discussion_r1242135665


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2373,6 +2373,11 @@
           "The ANALYZE TABLE command does not support views."
         ]
       },
+      "ATTACH_NAMESPACE_COMMENT" : {
+        "message" : [
+          "Attach namespace comment."

Review Comment:
   ```suggestion
             "Attach a comment to the namespace <namespace>."
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2468,6 +2478,11 @@
           "Python UDF in the ON clause of a <joinType> JOIN. In case of an INNNER JOIN consider rewriting to a CROSS JOIN with a WHERE clause."
         ]
       },
+      "REMOVE_NAMESPACE_COMMENT" : {
+        "message" : [
+          "Remove namespace comment."

Review Comment:
   ```suggestion
             "Remove a comment from the namespace <namespace>."
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2373,6 +2373,11 @@
           "The ANALYZE TABLE command does not support views."
         ]
       },
+      "ATTACH_NAMESPACE_COMMENT" : {

Review Comment:
   nit:
   ```suggestion
         "COMMENT_NAMESPACE" : {
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2388,6 +2393,11 @@
           "DESC TABLE COLUMN for a specific partition."
         ]
       },
+      "DROP_NAMESPACE_RESTRICT" : {
+        "message" : [
+          "Drop namespace restrict."

Review Comment:
   ```suggestion
             "Drop the namespace <namespace>."
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org