[jira] [Work logged] (BEAM-9558) Make end of data channel explicit

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-9558?focusedWorklogId=407169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407169 ]

ASF GitHub Bot logged work on BEAM-9558:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Mar/20 18:48
            Start Date: 20/Mar/20 18:48
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on issue #11173: [BEAM-9558] Add explicit end bit for data channel.
URL: https://github.com/apache/beam/pull/11173#issuecomment-601858195
 
 
   So I spent quite a bit of time refactoring things to do the separate "end all streams for this bundle" proposal that we discussed, and it turns out that gets quite messy. (One of the things that makes this less nice is, as things stand, there may be multiple data stream endpoints for a single bundle. The need to preserve ordering between the data and end markers across threads other than those handling the grpc request, and the fact that buffering streams need to flush so closing them all needs to happen anyway, reduces the potential wins.) Combined with the fact that it gets even uglier to try to support both modes simultaneously during any transition period, I'm just going to go for this simpler, original fix for now. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 407169)
    Time Spent: 0.5h  (was: 20m)

> Make end of data channel explicit
> ---------------------------------
>
>                 Key: BEAM-9558
>                 URL: https://issues.apache.org/jira/browse/BEAM-9558
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>             Fix For: 2.21.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently the end of a data channel is implicitly marked by sending an empty data block. The protocol would be simplified by making this explicit, and it would also prevent data loss bugs that might occur by accidentally sending an empty block. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)