You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2021/04/05 10:20:00 UTC
[jira] [Updated] (ISIS-2595) Translation context should be provided
consistently for collections/properties/services ...
[ https://issues.apache.org/jira/browse/ISIS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Keir Haywood updated ISIS-2595:
--------------------------------------
Description:
... as to whether an id or a name is used.
from [https://the-asf.slack.com/archives/CFC42LWBV/p1617614189183900]
Regarding translations, it seems that currently the ID of a collection is used as the reference text, not the name from the layout data
Line 317 in the GridSystemServiceAbstract class:
final String groupName = collectionLayoutData.getId();
final String sequence = "" + collectionSequence++;
addOrReplaceFacet(
new MemberOrderFacetXml(groupName, sequence, translationService, oneToManyAssociation));
groupName is then passed to the translation service as reference text
This is different from how properties work; (not looked at actions)
This is in the visitor for CollectionLayoutData.
~~~
To distill this: *why are the IDs of layouts used as reference texts for translations ?*
was:
... as to whether an id or a name is used.
from [https://the-asf.slack.com/archives/CFC42LWBV/p1617614189183900]
Regarding translations, it seems that currently the ID of a collection is used as the reference text, not the name from the layout data
Line 317 in the GridSystemServiceAbstract class:
final String groupName = collectionLayoutData.getId();
final String sequence = "" + collectionSequence++;
addOrReplaceFacet(
new MemberOrderFacetXml(groupName, sequence, translationService, oneToManyAssociation));
groupName is then passed to the translation service as reference text
This is different from how properties work; (not looked at actions)
This is in the visitor for CollectionLayoutData.
> Translation context should be provided consistently for collections/properties/services ...
> -------------------------------------------------------------------------------------------
>
> Key: ISIS-2595
> URL: https://issues.apache.org/jira/browse/ISIS-2595
> Project: Isis
> Issue Type: Improvement
> Affects Versions: 2.0.0-M5
> Reporter: Daniel Keir Haywood
> Priority: Minor
> Fix For: 2.0.0-M6
>
>
> ... as to whether an id or a name is used.
>
> from [https://the-asf.slack.com/archives/CFC42LWBV/p1617614189183900]
>
> Regarding translations, it seems that currently the ID of a collection is used as the reference text, not the name from the layout data
>
> Line 317 in the GridSystemServiceAbstract class:
> final String groupName = collectionLayoutData.getId();
> final String sequence = "" + collectionSequence++;
> addOrReplaceFacet(
> new MemberOrderFacetXml(groupName, sequence, translationService, oneToManyAssociation));
> groupName is then passed to the translation service as reference text
>
>
> This is different from how properties work; (not looked at actions)
>
> This is in the visitor for CollectionLayoutData.
>
> ~~~
> To distill this: *why are the IDs of layouts used as reference texts for translations ?*
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)