You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/29 05:44:58 UTC
[GitHub] [hudi] xushiyan commented on a diff in pull request #6817: [HUDI-4942] Fix RowSource schema provider
xushiyan commented on code in PR #6817:
URL: https://github.com/apache/hudi/pull/6817#discussion_r983086847
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/RowSource.java:
##########
@@ -41,6 +41,9 @@ public RowSource(TypedProperties props, JavaSparkContext sparkContext, SparkSess
@Override
protected final InputBatch<Dataset<Row>> fetchNewData(Option<String> lastCkptStr, long sourceLimit) {
Pair<Option<Dataset<Row>>, String> res = fetchNextBatch(lastCkptStr, sourceLimit);
+ if (overriddenSchemaProvider != null) {
+ return new InputBatch<>(res.getKey(), res.getValue(), overriddenSchemaProvider);
+ }
Review Comment:
`org.apache.hudi.utilities.sources.Source#fetchNext` actually checks and uses `overriddenSchemaProvider`.
And `fetchNewData()` is only used in `fetchNext()` . i think some misconfig caused the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org