You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2022/03/25 23:24:18 UTC
[GitHub] [mesos] andreaspeters opened a new pull request #422: FIX: mesos rpm add command and change mesos_isolation.
andreaspeters opened a new pull request #422:
URL: https://github.com/apache/mesos/pull/422
This PR will fix two failures.
1. During the building of the docker base image, it could not find the rpm file of mesos.
2. The mesos-agent didn't start. I had to change the mesos_isolation definition.
With these two changes, mesos-mini is working again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a change in pull request #422: FIX: mesos rpm add command and change mesos_isolation.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on a change in pull request #422:
URL: https://github.com/apache/mesos/pull/422#discussion_r839414964
##########
File path: support/packaging/centos/build-docker-centos.sh
##########
@@ -24,7 +24,7 @@ DOCKER_CONTEXT_DIR="${SOURCE_DIR}/centos${CENTOS_DISTRO}/rpmbuild/RPMS/x86_64"
cat <<EOF > "${DOCKER_CONTEXT_DIR}/Dockerfile"
FROM centos:${CENTOS_DISTRO}
-ADD mesos-?.?.?-*.rpm /
Review comment:
Yes! A single question-mark "?" is a wildcard for a single character. So it can't work for mesos greater 1.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] qianzhangxa commented on a change in pull request #422: FIX: mesos rpm add command and change mesos_isolation.
Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on a change in pull request #422:
URL: https://github.com/apache/mesos/pull/422#discussion_r839369156
##########
File path: support/mesos-mini/mesos/agent_environment
##########
@@ -3,7 +3,7 @@ MESOS_HOSTNAME=localhost
MESOS_WORK_DIR=/var/lib/mesos/agent
MESOS_MASTER=127.0.0.1:5050
MESOS_CONTAINERIZERS=mesos,docker
-MESOS_ISOLATION=filesystem/linux,network/cni,cgroups/cpu,cgroups/mem,cgroups/blkio,cgroups/devices,disk/du,docker/runtime,volume/sandbox_path,volume/host_path,posix/rlimits,namespaces/pid,linux/capabilities
Review comment:
So it is the `linux/capabilities` isolator causes Mesos agent cannot start, can you please paste the error log here? I'd like to know why agent fails to start.
##########
File path: support/packaging/centos/build-docker-centos.sh
##########
@@ -24,7 +24,7 @@ DOCKER_CONTEXT_DIR="${SOURCE_DIR}/centos${CENTOS_DISTRO}/rpmbuild/RPMS/x86_64"
cat <<EOF > "${DOCKER_CONTEXT_DIR}/Dockerfile"
FROM centos:${CENTOS_DISTRO}
-ADD mesos-?.?.?-*.rpm /
Review comment:
Can you please elaborate a bit on why `?.?.?` does not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a change in pull request #422: FIX: mesos rpm add command and change mesos_isolation.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on a change in pull request #422:
URL: https://github.com/apache/mesos/pull/422#discussion_r839414964
##########
File path: support/packaging/centos/build-docker-centos.sh
##########
@@ -24,7 +24,7 @@ DOCKER_CONTEXT_DIR="${SOURCE_DIR}/centos${CENTOS_DISTRO}/rpmbuild/RPMS/x86_64"
cat <<EOF > "${DOCKER_CONTEXT_DIR}/Dockerfile"
FROM centos:${CENTOS_DISTRO}
-ADD mesos-?.?.?-*.rpm /
Review comment:
Yes! A single question-mark "?" is a wildcard for a single character. So it can't work for mesos greater 1.9.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] andreaspeters commented on a change in pull request #422: FIX: mesos rpm add command and change mesos_isolation.
Posted by GitBox <gi...@apache.org>.
andreaspeters commented on a change in pull request #422:
URL: https://github.com/apache/mesos/pull/422#discussion_r839408530
##########
File path: support/mesos-mini/mesos/agent_environment
##########
@@ -3,7 +3,7 @@ MESOS_HOSTNAME=localhost
MESOS_WORK_DIR=/var/lib/mesos/agent
MESOS_MASTER=127.0.0.1:5050
MESOS_CONTAINERIZERS=mesos,docker
-MESOS_ISOLATION=filesystem/linux,network/cni,cgroups/cpu,cgroups/mem,cgroups/blkio,cgroups/devices,disk/du,docker/runtime,volume/sandbox_path,volume/host_path,posix/rlimits,namespaces/pid,linux/capabilities
Review comment:
No problem. :-)
```
Mar 31 09:57:55 andreas-pc mesos-agent[40]: Reached unreachable statement at linux/capabilities.cpp:497
Mar 31 09:57:55 andreas-pc mesos-agent[40]: *** Aborted at 1648720675 (unix time) try "date -d @1648720675" if you are using GNU date ***
Mar 31 09:57:55 andreas-pc mesos-agent[40]: PC: @ 0x7f2e97e6f387 __GI_raise
Mar 31 09:57:55 andreas-pc mesos-agent[40]: *** SIGABRT (@0x16) received by PID 22 (TID 0x7f2e9db92a00) from PID 22; stack trace: ***
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e98733630 (unknown)
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e97e6f387 __GI_raise
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e97e70a78 __GI_abort
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9ae164d7 Unreachable()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b81dba1 mesos::internal::capabilities::operator<<()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b8217ac stringify<>()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b820076 mesos::internal::capabilities::Capabilities::create()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b908c2d mesos::internal::slave::LinuxCapabilitiesIsolatorProcess::create()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b42f9ec std::_Function_handler<>::_M_invoke()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b41c9f2 mesos::internal::slave::MesosContainerizer::create()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e9b399696 mesos::internal::slave::Containerizer::create()
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x55d68541b10a (unknown)
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x7f2e97e5b555 __libc_start_main
Mar 31 09:57:55 andreas-pc mesos-agent[40]: @ 0x55d68541e221 (unknown)
Mar 31 09:57:56 andreas-pc systemd[1]: mesos-slave.service: main process exited, code=dumped, status=6/ABRT
Mar 31 09:57:56 andreas-pc systemd[1]: Unit mesos-slave.service entered failed state.
Mar 31 09:57:56 andreas-pc systemd[1]: mesos-slave.service failed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org