You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/09/24 05:39:35 UTC
[GitHub] [incubator-opendal] tisonkun opened a new pull request, #3168: build(bindings/java): support explicit cargo build target
tisonkun opened a new pull request, #3168:
URL: https://github.com/apache/incubator-opendal/pull/3168
This closes https://github.com/apache/incubator-opendal/issues/3160.
With this patch, it's expected to fix the original issue with:
```
./mvnw verify -Dcargo-build.target=x86_64-unknown-linux-musl
```
@G-XD please give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #3168: build(bindings/java): support explicit cargo build target
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3168:
URL: https://github.com/apache/incubator-opendal/pull/3168#issuecomment-1732491433
I work out a hack with suggestions at https://github.com/rust-lang/rust/issues/44991.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #3168: build(bindings/java): support explicit cargo build target
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3168:
URL: https://github.com/apache/incubator-opendal/pull/3168#issuecomment-1732502375
Still you need to have musl-gcc installed or proper GLIBC version installed. There is little things we can help in this perspective.
But support explicit cargo build target helps users build with other toolchain so it's still valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #3168: build(bindings/java): support explicit cargo build target
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3168:
URL: https://github.com/apache/incubator-opendal/pull/3168#issuecomment-1732490765
No. musl doesn't support dynamic linking. So basically it requires a container env for building.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #3168: build(bindings/java): support explicit cargo build target
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3168:
URL: https://github.com/apache/incubator-opendal/pull/3168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3168: build(bindings/java): support explicit cargo build target
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3168:
URL: https://github.com/apache/incubator-opendal/pull/3168#discussion_r1335133110
##########
bindings/java/.cargo/config:
##########
@@ -0,0 +1,9 @@
+[target.x86_64-unknown-linux-musl]
Review Comment:
```suggestion
# See also https://github.com/rust-lang/rust/issues/44991
[target.x86_64-unknown-linux-musl]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun closed pull request #3168: build(bindings/java): support explicit cargo build target
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed pull request #3168: build(bindings/java): support explicit cargo build target
URL: https://github.com/apache/incubator-opendal/pull/3168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org