[GitHub] [incubator-druid] swapneshgandhi commented on a change in pull request #8272: Support incremental load in Druid lookups

[GitBox <gi...@apache.org>]

swapneshgandhi commented on a change in pull request #8272: Support incremental load in Druid lookups
URL: https://github.com/apache/incubator-druid/pull/8272#discussion_r319303525
 
 

 ##########
 File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/cache/OnHeapNamespaceExtractionCacheManager.java
 ##########
 @@ -91,6 +91,15 @@ public CacheHandler createCache()
     return new CacheHandler(this, cache, cacheRef);
   }
 
+  @Override
+  public CacheHandler createCache(ConcurrentMap<String, String> cache)
+  {
+    WeakReference<ConcurrentMap<String, String>> cacheRef = new WeakReference<>(cache);
 
 Review comment:
   I am looking to fix this by reusing same `cacheHandler` objects and not messing with `NamespaceExtractionCacheManager` at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org