You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 16:52:08 UTC

[GitHub] [arrow] fatemehp commented on pull request #14509: PARQUET-2204: [parquet-cpp] TypedColumnReaderImpl::Skip should reuse scratch space

fatemehp commented on PR #14509:
URL: https://github.com/apache/arrow/pull/14509#issuecomment-1298825412

   @emkornfield Could you give some context about when we normally use the feature flags? If we want to control this using a flag, that means we will support both cases of 1) allocating within the Skip function and 2) in the column reader. I am wondering if that is doing more than what we need.
   
   Also, I don't fully understand your question here: "This breaks only after a second call to skip?"
   The scratch space is allocated on the "first" call to skip and will be retained until the column reader is destroyed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org