You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by tr...@apache.org on 2016/12/07 02:07:07 UTC

svn commit: r1773002 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java

Author: tripod
Date: Wed Dec  7 02:07:07 2016
New Revision: 1773002

URL: http://svn.apache.org/viewvc?rev=1773002&view=rev
Log:
OAK-5229 Using Node.setPrimaryType() should fail if non-matching childnodes

- adding "ignored" test that shows the behavior

Modified:
    jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java

Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java?rev=1773002&r1=1773001&r2=1773002&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java Wed Dec  7 02:07:07 2016
@@ -1872,6 +1872,35 @@ public class RepositoryTest extends Abst
     }
 
     @Test
+    @Ignore("OAK-5229")
+    public void setPrimaryTypeShouldFail() throws RepositoryException {
+        Node testNode = getNode(TEST_PATH);
+        assertEquals("nt:unstructured", testNode.getPrimaryNodeType().getName());
+        assertEquals("nt:unstructured", testNode.getProperty("jcr:primaryType").getString());
+
+        // create subnode that would not be allowed with nt:folder
+        testNode.addNode("unstructured_child", NodeType.NT_UNSTRUCTURED);
+        getAdminSession().save();
+
+        testNode.setPrimaryType("nt:folder");
+        try {
+            getAdminSession().save();
+            fail("Changing the primary type to nt:folder should fail.");
+        } catch (RepositoryException e) {
+            // ok
+        }
+
+        Session session2 = createAnonymousSession();
+        try {
+            testNode = session2.getNode(TEST_PATH);
+            assertEquals("nt:unstructured", testNode.getPrimaryNodeType().getName());
+            assertEquals("nt:unstructured", testNode.getProperty("jcr:primaryType").getString());
+        } finally {
+            session2.logout();
+        }
+    }
+
+    @Test
     public void nodeTypeRegistry() throws RepositoryException {
         NodeTypeManager ntMgr = getAdminSession().getWorkspace().getNodeTypeManager();
         assertFalse(ntMgr.hasNodeType("foo"));