You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/11/21 04:32:19 UTC
[kudu-CR] [webui] fixed build and corrected a typo
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11973
Change subject: [webui] fixed build and corrected a typo
......................................................................
[webui] fixed build and corrected a typo
Fixed build for TCMALLOC-enabled environments.
Fixed a typo in 'Memory usage by subsystem' WebUI page.
This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3.
Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
---
M src/kudu/server/default_path_handlers.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11973/1
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 16:19:24 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 5:
> Uh oh. I didn't mean to upload a new patch set for this. I
> temporarily rebased a change onto a previous version of this patch
> to unbreak my build, and then forgot about that and submitted a new
> change to gerrit. :(
> Uh oh. I didn't mean to upload a new patch set for this. I
> temporarily rebased a change onto a previous version of this patch
> to unbreak my build, and then forgot about that and submitted a new
> change to gerrit. :(
No problem -- I submitted a small update, cleaning up a few tiny things.
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 16:16:59 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [webui] fixed build and corrected a typo
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
[webui] fixed build and corrected a typo
Fixed build for TCMALLOC-enabled environments.
Fixed a typo in 'Memory usage by subsystem' WebUI page.
As additional tiny change, take advantage of the 'using' directive
for std::ostringstream.
This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3.
Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Reviewed-on: http://gerrit.cloudera.org:8080/11973
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/server/default_path_handlers.cc
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11973
to look at the new patch set (#2).
Change subject: [webui] fixed build and corrected a typo
......................................................................
[webui] fixed build and corrected a typo
Fixed build for TCMALLOC-enabled environments.
Fixed a typo in 'Memory usage by subsystem' WebUI page.
This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3.
Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
---
M src/kudu/server/default_path_handlers.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11973/2
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 10:22:57 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11973
to look at the new patch set (#3).
Change subject: [webui] fixed build and corrected a typo
......................................................................
[webui] fixed build and corrected a typo
Fixed build for TCMALLOC-enabled environments.
Fixed a typo in 'Memory usage by subsystem' WebUI page.
This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3.
Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
---
M src/kudu/server/default_path_handlers.cc
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11973/3
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 1: Verified-1
Actually, we shouldn't commit this without the pragma keep, otherwise future patches in the area will fail in a similar way.
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 05:52:40 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11973
to look at the new patch set (#5).
Change subject: [webui] fixed build and corrected a typo
......................................................................
[webui] fixed build and corrected a typo
Fixed build for TCMALLOC-enabled environments.
Fixed a typo in 'Memory usage by subsystem' WebUI page.
As additional tiny change, take advantage of the 'using' directive
for std::ostringstream.
This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3.
Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
---
M src/kudu/server/default_path_handlers.cc
1 file changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11973/5
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 1: Code-Review+2
I removed those because IWYU told me to. -.-
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 04:40:02 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 4:
Uh oh. I didn't mean to upload a new patch set for this. I temporarily rebased a change onto a previous version of this patch to unbreak my build, and then forgot about that and submitted a new change to gerrit. :(
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 12:21:33 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Yeah, not sure why IWYU is complaining. Perhaps we need to add pragma keep here.
There was also a flaky test.
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 05:30:02 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 2:
> I removed those because IWYU told me to. -.-
Yup, IWYU misguide people when a different set of macros defined. Adding corresponding ifdefs around those #includes or pragmas would help.
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 09:31:05 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has uploaded a new patch set (#4) to the change originally created by Alexey Serbin. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
[webui] fixed build and corrected a typo
Fixed build for TCMALLOC-enabled environments.
Fixed a typo in 'Memory usage by subsystem' WebUI page.
This is a follow-up to 7437626f42b30811720d59e792bc905662efd2b3.
Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
---
M src/kudu/server/default_path_handlers.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11973/4
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 16:40:13 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] fixed build and corrected a typo
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11973 )
Change subject: [webui] fixed build and corrected a typo
......................................................................
Patch Set 5:
> No problem -- I submitted a small update, cleaning up a few tiny
> things.
Thanks. Let's get this committed so I don't shoot you in the foot again. :)
--
To view, visit http://gerrit.cloudera.org:8080/11973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1f0b3df0ac4178609914322741511d8fff87b24
Gerrit-Change-Number: 11973
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 16:28:11 +0000
Gerrit-HasComments: No