[GitHub] [skywalking-java] gzlicanyi commented on a diff in pull request #538: Fix the gson dependency in the kafka-reporter-plugin. (#10848)

["gzlicanyi (via GitHub)" <gi...@apache.org>]

gzlicanyi commented on code in PR #538:
URL: https://github.com/apache/skywalking-java/pull/538#discussion_r1206510217


##########
apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/pom.xml:
##########
@@ -28,12 +28,21 @@
     <artifactId>kafka-reporter-plugin</artifactId>
     <packaging>jar</packaging>
 
+    <properties>
+        <shade.com.google.source>com.google</shade.com.google.source>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.apache.kafka</groupId>
             <artifactId>kafka-clients</artifactId>
             <version>${kafka-clients.version}</version>
         </dependency>
+        <dependency>

Review Comment:
   This is old code. Similar to Gson, the kafka-reporter-plugin does not use any dependencies from apm-agent-core.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org