You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2021/03/20 01:13:11 UTC
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17212
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
IMPALA-10592: prevent pytest from hanging at exit.
In TestAdmissionControllerStress mark worker threads as daemons so that
an exception in teardown() will not cause pytest to hang just after
printing the test results.
https://stackoverflow.com/questions/19219596/py-test-hangs-after-showing-test-results
TESTING:
Simulated the failure in IMPALA-10596 by throwing an exception during
teardown(). Without this fix the pytest invocation hangs.
Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/17212/1
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17212 )
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8412/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Mar 2021 01:32:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17212 )
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6991/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 17:42:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17212 )
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 17:42:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17212 )
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 17:27:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17212 )
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Mar 2021 23:33:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17212 )
Change subject: IMPALA-10592: prevent pytest from hanging at exit.
......................................................................
IMPALA-10592: prevent pytest from hanging at exit.
In TestAdmissionControllerStress mark worker threads as daemons so that
an exception in teardown() will not cause pytest to hang just after
printing the test results.
https://stackoverflow.com/questions/19219596/py-test-hangs-after-showing-test-results
TESTING:
Simulated the failure in IMPALA-10596 by throwing an exception during
teardown(). Without this fix the pytest invocation hangs.
Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Reviewed-on: http://gerrit.cloudera.org:8080/17212
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I74cca8f577c7fbc4d394311e2f039cf4f68b08df
Gerrit-Change-Number: 17212
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>