You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/03 05:07:11 UTC

[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6580: [Veeam] Improve remove backup process

harikrishna-patnala commented on code in PR #6580:
URL: https://github.com/apache/cloudstack/pull/6580#discussion_r936238728


##########
api/src/main/java/org/apache/cloudstack/api/command/user/backup/DeleteBackupCmd.java:
##########
@@ -61,6 +62,13 @@ public class DeleteBackupCmd  extends BaseAsyncCmd {
             description = "id of the VM backup")
     private Long backupId;
 
+    @Parameter(name = ApiConstants.FORCED,
+            type = CommandType.BOOLEAN,
+            required = false,
+            description = "force the deletion of backup",

Review Comment:
   Can you please change the description to something like "force the deletion of backup which removes the entire backup chain but keep VM in Backup Offering"? Otherwise, the force parameter looks to me like "force delete just this backup in any case".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org