[GitHub] [spark] HyukjinKwon commented on a change in pull request #31436: [SPARK-34327][BUILD] Strip passwords from inlining into build information while releasing.

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #31436:
URL: https://github.com/apache/spark/pull/31436#discussion_r569028118



##########
File path: build/spark-build-info
##########
@@ -32,7 +32,7 @@ echo_build_properties() {
   echo revision=$(git rev-parse HEAD)
   echo branch=$(git rev-parse --abbrev-ref HEAD)
   echo date=$(date -u +%Y-%m-%dT%H:%M:%SZ)
-  echo url=$(git config --get remote.origin.url)
+  echo url=$(git config --get remote.origin.url |  sed 's|https://\(.*\)@\(.*\)|https://\2|')

Review comment:
       BTW does it cover the case when the password contains `@`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org