[GitHub] [airflow] kaxil commented on a change in pull request #13861: Remove azure-storage hack

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#discussion_r563214593



##########
File path: Dockerfile
##########
@@ -198,6 +198,11 @@ COPY scripts/docker/install_airflow_from_latest_master.sh /scripts/docker/instal
 ARG UPGRADE_TO_NEWER_DEPENDENCIES="false"
 ENV UPGRADE_TO_NEWER_DEPENDENCIES=${UPGRADE_TO_NEWER_DEPENDENCIES}
 
+# By changing CI build epoch we can force reinstalling Airflow from the current master
+# It can also be overwritten manually by setting the AIRFLOW_BUILD_EPOCH environment variable.
+ARG AIRFLOW_BUILD_EPOCH="1"
+ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}

Review comment:
       Shouldn't it be one of the following two:
   
   ```suggestion
   ARG AIRFLOW_CI_BUILD_EPOCH="1"
   ENV AIRFLOW_CI_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}
   ```
   
   or
   
   ```suggestion
   ARG AIRFLOW_BUILD_EPOCH="1"
   ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_BUILD_EPOCH}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org