You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/15 21:40:23 UTC

[GitHub] [netbeans] tbw777 commented on a diff in pull request #5477: Cleanup by simplifying strings comparsion with JDK7 Objects.equals(). Part 2.

tbw777 commented on code in PR #5477:
URL: https://github.com/apache/netbeans/pull/5477#discussion_r1107755021


##########
enterprise/j2ee.sun.appsrv/src/org/netbeans/modules/j2ee/sun/api/restricted/ResourceConfigurator.java:
##########
@@ -570,8 +570,7 @@ private String isSameDatabaseConnection(JdbcConnectionPool connPool, String data
                 if ((databaseUrl.indexOf(serverPort) != -1)
                         && ((databaseUrl.indexOf(databaseName) != -1)
                         || (databaseUrl.indexOf(sid) != -1))) {
-                    if ((username != null && user.equals(username))
-                            && (password != null && pwd.equals(password))) {
+                    if (user.equals(username) && pwd.equals(password)) {

Review Comment:
   its revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists