You are viewing a plain text version of this content. The canonical link for it is here.
Posted to httpclient-users@hc.apache.org by Yongxing Wang <yo...@yahoo.com> on 2010/09/01 01:55:44 UTC
can not dowload file size greater than Integer.MAX_VALUE
Oleg,
We are using HTTP NIO in our production env and we recently found out that we
can not download any file with size greater than Integer.MAX_VALUE. The amount
of data we can download is always "actual_file_size - Integer.MAX_VALUE" in that
case.
Further looking into the code, I have found that the implementation of
LengthDelimitedDecoder there is a line of code:
int lenRemaining = (int) (this.contentLength - this.len);
I believe the cast to int is causing the problem when contentLength is over 4G.
Once I changed lenRemaining to long and make other necessary changes to let it
compile, it works like charm.
Please take a look and let me know whether it is legitimate.
Thanks,
Yong
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org
Re: can not dowload file size greater than Integer.MAX_VALUE
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Tue, 2010-08-31 at 16:55 -0700, Yongxing Wang wrote:
>
> Oleg,
>
> We are using HTTP NIO in our production env and we recently found out that we
> can not download any file with size greater than Integer.MAX_VALUE. The amount
> of data we can download is always "actual_file_size - Integer.MAX_VALUE" in that
> case.
>
> Further looking into the code, I have found that the implementation of
> LengthDelimitedDecoder there is a line of code:
>
> int lenRemaining = (int) (this.contentLength - this.len);
>
> I believe the cast to int is causing the problem when contentLength is over 4G.
> Once I changed lenRemaining to long and make other necessary changes to let it
> compile, it works like charm.
>
> Please take a look and let me know whether it is legitimate.
>
Hi Yong
Yes, it is. This is obviously a bug. Please raise a JIRA for this defect
[1]. Please also consider generating a patch with your changes and
contributing it to the project.
Cheers
Oleg
[1] https://issues.apache.org/jira/browse/HTTPCORE
> Thanks,
> Yong
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> For additional commands, e-mail: httpclient-users-help@hc.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org