[GitHub] tcole3 commented on issue #31: Incorporate Web Annotation testing tools

[GitBox <gi...@apache.org>]

tcole3 commented on issue #31: Incorporate Web Annotation testing tools
URL: https://github.com/apache/incubator-annotator/issues/31#issuecomment-396078949
 
 
   The schemas at https://github.com/w3c/web-annotation-tests conform to draft-04 of json schema. draft-07 (http://json-schema.org/specification.html) is the current version. Schemas were developed almost 2 years ago using then current versions of node.js and ajv  (another json validator - https://www.npmjs.com/package/ajv). Updating to newer version of json schema will allow some simplifications (avoid, for example, double negatives when checking arrays). 
   
   Please note the reliance on 'referenced' schemas, i.e., the actual schema confirming that an annotation meets a requirement of the Web Annotation Data Model typically relies on 2 or 3 referenced schemas which live in different file(s) and are shared across multiple schemas (https://github.com/w3c/web-annotation-tests/tree/master/definitions). Ajv makes it easy to load referenced schemas asynchronously (https://www.npmjs.com/package/ajv#asynchronous-schema-compilation). 
   
   Also, there are known to be mistakes in 2 or 3 of the schemas (will pass an incorrect annotation or fail a correct annotation), but these only show up in truly edge cases of the data model and will be easy to fix at a later time. 
   
   I'm not currently a committer on annotator-incubator, but happy to help if any questions about the schemas themselves or if there's anything else I can help with. Happy also to take another run at my management to get approvals necessary to be added as a committer for the incubator. 
   
   @BigBlueHat sounds like Saturday hack work went well. Sorry I couldn't stick around for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services