You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by shweta agarwal <sh...@citrix.com> on 2015/02/03 11:41:41 UTC
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70731
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116115>
why are we setting these value in seconds ? by default this config value is required in mins.
and are we setting configs[0].value somewhere during setup so that here you are trying to increase by a min? by default this parameter value is 1440 (24hrs)
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116116>
when do you expect to get unknown in response ?
service cloudstack-usage status command output will be something like
cloudstack-usage is stopped
or
cloudstack-usage is running
- shweta agarwal
On Jan. 30, 2015, 4:29 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 4:29 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 141
> > <https://reviews.apache.org/r/28030/diff/2/?file=841878#file841878line141>
> >
> > why are we setting these value in seconds ? by default this config value is required in mins.
> > and are we setting configs[0].value somewhere during setup so that here you are trying to increase by a min? by default this parameter value is 1440 (24hrs)
We are just listing the value here and increasing it by one minute. And it is converted to seconds because it is used in time.sleep() function.
The value is used while waiting for usage job to run. Once the sleep period is over, generateUsage command is fired and usage is listed.
While setting the range, value is passed in minutes only. (See line number 201)
> On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 266
> > <https://reviews.apache.org/r/28030/diff/2/?file=841878#file841878line266>
> >
> > when do you expect to get unknown in response ?
> >
> > service cloudstack-usage status command output will be something like
> > cloudstack-usage is stopped
> >
> > or
> >
> > cloudstack-usage is running
When usage server is not installed, then we will get "unknown" while checking the status.
It is assumed that if the usage server is installed, then it is running.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70731
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>