[GitHub] [commons-beanutils] jvz commented on a change in pull request #10: BEANUTILS-528: New converters for UUID, URI, and Path.

[GitBox <gi...@apache.org>]

jvz commented on a change in pull request #10: BEANUTILS-528: New converters for UUID, URI, and Path.
URL: https://github.com/apache/commons-beanutils/pull/10#discussion_r337069466
 
 

 ##########
 File path: src/main/java/org/apache/commons/beanutils2/converters/PathConverter.java
 ##########
 @@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.beanutils2.converters;
+
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/**
+ * {@link org.apache.commons.beanutils2.Converter} implementation that handles conversion
+ * to and from <b>java.nio.file.Path</b> objects.
+ * <p>
+ * Can be configured to either return a <i>default value</i> or throw a
+ * <code>ConversionException</code> if a conversion error occurs.
+ *
+ * @since 2.0
+ */
+public final class PathConverter extends AbstractConverter {
+
+    /**
+     * Construct a <b>java.nio.file.Path</b> <i>Converter</i> that throws
+     * a <code>ConversionException</code> if an error occurs.
+     */
+    public PathConverter() {
+        super();
+    }
+
+    /**
+     * Construct a <b>java.nio.file.Path</b> <i>Converter</i> that returns
+     * a default value if an error occurs.
+     *
+     * @param defaultValue The default value to be returned
+     * if the value to be converted is missing or an error
+     * occurs converting the value.
+     */
+    public PathConverter(final Object defaultValue) {
+        super(defaultValue);
+    }
+
+    /**
+     * Return the default type this <code>Converter</code> handles.
+     *
+     * @return The default type this <code>Converter</code> handles.
+     * @since 2.0
+     */
+    @Override
+    protected Class<?> getDefaultType() {
+        return Path.class;
+    }
+
+    /**
+     * <p>Convert a java.nio.file.Path or object into a String.</p>
+     *
+     * @param <T> Target type of the conversion.
+     * @param type Data type to which this value should be converted.
+     * @param value The input value to be converted.
+     * @return The converted value.
+     * @throws Throwable if an error occurs converting to the specified type
+     * @since 2.0
+     */
+    @Override
+    protected <T> T convertToType(final Class<T> type, final Object value) throws Throwable {
+        if (Path.class.equals(type)) {
+            return type.cast(Paths.get(String.valueOf(value)));
 
 Review comment:
   Doing a cast here is redundant unless you change the `if` statement to check `Path.class.isAssignableFrom(type)`. Then you can support `Path` and subclasses.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services