You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/21 10:38:07 UTC

[GitHub] [maven] rfscholte commented on a change in pull request #306: [MNG-5982] Pass user properties to ModelBuildingRequest

rfscholte commented on a change in pull request #306:
URL: https://github.com/apache/maven/pull/306#discussion_r443206018



##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
##########
@@ -275,6 +275,7 @@ private Model loadPom( RepositorySystemSession session, ArtifactDescriptorReques
                 modelRequest.setTwoPhaseBuilding( false );
                 modelRequest.setSystemProperties( toProperties( session.getUserProperties(),
                                                                 session.getSystemProperties() ) );
+                modelRequest.setUserProperties( toProperties( session.getUserProperties(), null ) );

Review comment:
       This also means, that the line above it should be reduced to `modelRequest.setSystemProperties( toProperties( session.getSystemProperties() ) );`
   Next you need to analyze where it is used, and figure out if that code should be changed. It is an internal package, so it suggests such changes should be safe.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org