You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2016/04/27 20:27:33 UTC

[1/2] qpid-proton git commit: NO-JIRA: Fix/suppress warnings from the Perl swig binding.

Repository: qpid-proton
Updated Branches:
  refs/heads/master ab8a5d827 -> 0673b55f2


NO-JIRA: Fix/suppress warnings from the Perl swig binding.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/f44e7cda
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/f44e7cda
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/f44e7cda

Branch: refs/heads/master
Commit: f44e7cdabc4fbc1cfde455b2f6cd8d454b1e3c8e
Parents: ab8a5d8
Author: Alan Conway <ac...@redhat.com>
Authored: Wed Apr 27 13:49:36 2016 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Apr 27 13:50:21 2016 -0400

----------------------------------------------------------------------
 proton-c/bindings/perl/CMakeLists.txt | 9 +++++++++
 proton-c/bindings/perl/perl.i         | 3 +++
 proton-c/include/proton/cproton.i     | 2 +-
 3 files changed, 13 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/f44e7cda/proton-c/bindings/perl/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/proton-c/bindings/perl/CMakeLists.txt b/proton-c/bindings/perl/CMakeLists.txt
index 4f223f0..4930a43 100644
--- a/proton-c/bindings/perl/CMakeLists.txt
+++ b/proton-c/bindings/perl/CMakeLists.txt
@@ -17,6 +17,15 @@
 # under the License.
 #
 
+# Disable harmlesss warnings from the generted perlPERL_wrap.c
+include(CheckCCompilerFlag)
+foreach(flag -Wno-unused-but-set-variable -Wno-unused-function -Wno-unused-variable)
+  check_c_compiler_flag(${flag} allowed)
+  if (allowed)
+    add_compile_options(${flag})
+  endif()
+endforeach()
+
 include_directories("${PERL_INCLUDE_PATH}")
 
 # Always need to treat SWIG files as C

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/f44e7cda/proton-c/bindings/perl/perl.i
----------------------------------------------------------------------
diff --git a/proton-c/bindings/perl/perl.i b/proton-c/bindings/perl/perl.i
index 9b0c2d0..ebc6915 100644
--- a/proton-c/bindings/perl/perl.i
+++ b/proton-c/bindings/perl/perl.i
@@ -78,6 +78,9 @@
           }
       }
       break;
+
+    default:
+      break;
     }
 
   $result = obj;

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/f44e7cda/proton-c/include/proton/cproton.i
----------------------------------------------------------------------
diff --git a/proton-c/include/proton/cproton.i b/proton-c/include/proton/cproton.i
index c4e877b..95f07af 100644
--- a/proton-c/include/proton/cproton.i
+++ b/proton-c/include/proton/cproton.i
@@ -915,7 +915,7 @@ typedef unsigned long int uintptr_t;
 %contract pn_messenger(const char *name)
 {
  ensure:
-  pn_message != NULL;
+  name != NULL;
 }
 
 %contract pn_messenger_name(pn_messenger_t *messenger)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[2/2] qpid-proton git commit: NO-JIRA: Fix incorrect swig contract.

Posted by ac...@apache.org.
NO-JIRA: Fix incorrect swig contract.

Introduced in f44e7cdabc4fbc1cfde455b2f6cd8d454b1e3c8e.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/0673b55f
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/0673b55f
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/0673b55f

Branch: refs/heads/master
Commit: 0673b55f28b329223eaeea4fa433fdcff9ab03c8
Parents: f44e7cd
Author: Alan Conway <ac...@redhat.com>
Authored: Wed Apr 27 14:22:46 2016 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Apr 27 14:22:46 2016 -0400

----------------------------------------------------------------------
 proton-c/include/proton/cproton.i | 6 ------
 1 file changed, 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/0673b55f/proton-c/include/proton/cproton.i
----------------------------------------------------------------------
diff --git a/proton-c/include/proton/cproton.i b/proton-c/include/proton/cproton.i
index 95f07af..36153da 100644
--- a/proton-c/include/proton/cproton.i
+++ b/proton-c/include/proton/cproton.i
@@ -912,12 +912,6 @@ typedef unsigned long int uintptr_t;
 
 %include "proton/sasl.h"
 
-%contract pn_messenger(const char *name)
-{
- ensure:
-  name != NULL;
-}
-
 %contract pn_messenger_name(pn_messenger_t *messenger)
 {
  require:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org