You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/10/20 23:23:02 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1894: Fix log format in instanceValidationUtil
xyuanlu opened a new pull request #1894:
URL: https://github.com/apache/helix/pull/1894
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
The original log does not have String.format(). So the log contains "%s" and needed info is not included.
This change fix this issue.
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Small log fix.
### Tests
- [X] The following tests are written for this issue:
NA
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1894: Fix log format in instanceValidationUtil
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1894:
URL: https://github.com/apache/helix/pull/1894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1894: Fix log format in instanceValidationUtil
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1894:
URL: https://github.com/apache/helix/pull/1894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1894: Fix log format in instanceValidationUtil
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1894:
URL: https://github.com/apache/helix/pull/1894#discussion_r734711384
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -169,9 +169,9 @@ public static boolean hasValidConfig(HelixDataAccessor dataAccessor, String clus
return false;
}
if (!clusterConfig.isPersistIntermediateAssignment()) {
- _logger.error(
+ _logger.error(String.format(
Review comment:
TFTR. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1894: Fix log format in instanceValidationUtil
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1894:
URL: https://github.com/apache/helix/pull/1894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1894: Fix log format in instanceValidationUtil
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1894:
URL: https://github.com/apache/helix/pull/1894#discussion_r734695541
##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -169,9 +169,9 @@ public static boolean hasValidConfig(HelixDataAccessor dataAccessor, String clus
return false;
}
if (!clusterConfig.isPersistIntermediateAssignment()) {
- _logger.error(
+ _logger.error(String.format(
Review comment:
Use {} in the log string, please. FYI, https://garygregory.wordpress.com/2015/09/16/a-gentle-introduction-to-the-log4j-api-and-lambda-basics/
Good catch, BTW!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1894: Fix log format in instanceValidationUtil
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1894:
URL: https://github.com/apache/helix/pull/1894#issuecomment-954162343
This PR is ready to be merged. Approved by @junkaixue
Commit message:
Fix log format in instanceValidationUtil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org